Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents actors under active Gap Gen from being auto-targeted. #8203

Closed
wants to merge 1 commit into from

Conversation

deniz1a
Copy link
Contributor

@deniz1a deniz1a commented May 20, 2015

Depends on #8202. This patch makes units/buildings under active gap generator not auto targetable.

@pchote
Copy link
Member

pchote commented May 22, 2015

This is still working around implementation bugs in the spy satellite, right?

As i've said before (many times over the years), the GPS needs to be reimplemented properly instead of adding shims to all of the surrounding code to work around its issues.

@deniz1a
Copy link
Contributor Author

deniz1a commented May 22, 2015

Oh this has to be fixed in satellite code too? Ok then closing it.

@deniz1a deniz1a closed this May 22, 2015
@deniz1a
Copy link
Contributor Author

deniz1a commented May 22, 2015

So what should be in satellite code? Targetability, checks for gap gens?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants