Refactor TypeDictionary #8625
Merged
Refactor TypeDictionary #8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoosterDragon
force-pushed
the
type-dict-refactor
branch
from
5c5cbb3
to
54e7c0b
Compare
- When removing entries, ensure the dictionary entry is removed is the list is emptied, to prevent incorrect lookups later. - Prevent NRE when calling GetOrDefault<T> where T is a value type and the default is returned. - Use a single dictionary for simplicity and improved lookup performance (since there is only one dictionary to check). - De-duplicate code in Get and GetOrDefault.
|
Can't spot regressions in-game. ✅ |
|
Code looks good and game still works 👍 I have no idea how to changelog this though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of potential bugs:
General code cleanup: