minor LUA and trait documentation fixes, whitespace fixes #9134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clemty
commented
Aug 22, 2015
clemty
commented
- Typo in documentation ("proximitry").
- Add spaces between sentences.
- Remove most occurrences of " " (two spaces) unless clearly used as indendation
- Punctuation (although no fullstop after filenames like "notifications.yaml").
clemty
changed the title
| * Then given the list of code lengths length[0..n-1] representing a canonical | ||
| * Huffman code for n symbols, construct the tables required to decode those | ||
| * codes. Those tables are the number of codes of each length, and the symbols | ||
| * codes. Those tables are the number of codes of each length, and the symbols |
There was a problem hiding this comment.
I believe @pchote is adding these double spaces on purpose.
|
👍 with above answered. |
|
Needs rebase. |
- Typo in documentation ("proximitry").
- Add spaces between sentences.
- Remove most occurrences of " " (two spaces) unless clearly used as indendation
- Punctuation (although no fullstop after filenames like "notifications.yaml").
|
reverted double spaces in comments & rebased |
| @@ -155,7 +155,7 @@ public MPos Clamp(MPos uv) | |||
| // Helper functions | |||
| public static class CellLayer | |||
| { | |||
| /// <summary>Create a new layer by resizing another layer. New cells are filled with defaultValue.</summary> | |||
There was a problem hiding this comment.
This might have been intentional as well.
There was a problem hiding this comment.
this looks like html to me, and multiple whitespace characters get filtered on display? or are tags like these used by IDEs too?
There was a problem hiding this comment.
<summary> is an IDE thing for code documentation and easy lookup. But I'm voting for keeping your change anyway.
|
👍 |
reaperrr
added a commit
that referenced
this pull request
Aug 24, 2015
minor LUA and trait documentation fixes, whitespace fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.