Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D2k fix for cliff passability #9185

Merged
merged 1 commit into from Aug 28, 2015
Merged

D2k fix for cliff passability #9185

merged 1 commit into from Aug 28, 2015

Conversation

reaperrr
Copy link
Contributor

Fixes passability on some d2k cliffs.

@reaperrr reaperrr changed the title D2k fixes D2k fixes for aircraft visibility under fog and cliff passability Aug 28, 2015
pchote
pchote reviewed Aug 28, 2015
View reviewed changes
mods/d2k/rules/defaults.yaml
@@ -237,7 +239,7 @@
Inherits@1: ^ExistsInWorld
AppearsOnRadar:
UseLocation: yes
HiddenUnderFog:
HiddenUnderShroud:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes them visible for everyone under the fog, but we want them to be visible to only the owner and their allies.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see.

@pchote
Copy link
Member

pchote commented Aug 28, 2015

After refreshing my memory on the history behind #9166, I think we shouldn't fix it (its a feature, not a bug).

@reaperrr reaperrr changed the title D2k fixes for aircraft visibility under fog and cliff passability D2k fix for cliff passability Aug 28, 2015
@reaperrr
Copy link
Contributor Author

Updated.

After refreshing my memory on the history behind #9166, I think we shouldn't fix it (its a feature, not a bug).

#9106 wants to "fix" this as well though, meaning we've now had at least two people who considered it a bug (or at least inconvenience), so we should at least keep an eye on this.

@GraionDilach
Copy link
Contributor

Although that PR also has this included, but I guess this can go without that so 👍

@reaperrr
Copy link
Contributor Author

It may take a while until that is mergable, and this here might still make it into the playtest/release.

Mailaender added a commit that referenced this pull request Aug 28, 2015
@Mailaender
Merge pull request #9185 from reaperrr/d2k-fixes
a0bdce9 
D2k fix for cliff passability
@Mailaender Mailaender merged commit a0bdce9 into OpenRA:bleed Aug 28, 2015
@Mailaender
Copy link
Member

Thanks.

@Mailaender
Copy link
Member

Changelog

@reaperrr reaperrr deleted the d2k-fixes branch October 21, 2015 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reaperrr @pchote @GraionDilach @Mailaender