Add team chat for spectators

[abcdefg30]

Closes #2062.

[deniz1a]

When a player loses and becomes spectator, will he have the same team chat indicator as he did during game? Because that could be confusing, team chat would no longer mean the same thing. How about calling it something like "Spectator chat"?

[abcdefg30]

Unfortunately it doesn't do that, but it's also another issue, I think: #4772.

[pchote]

We should clearly distinguish between spectator and team chat, in that case.

[abcdefg30]

Updated. Using (Spectators) instead of (Team) now.

[Mailaender]

Works as promised. ✅

[Micr0Bit]

does that mean , we want "defeated players" (therefor having fog and shroud turned off for him) , to still help their team by telling them in the teamchat what the enemy is doing ?

so nobody else can read that ?

[pchote]

If the existing (before this pr) behaviour does that, then I don't think we need hold this PR up over it. We should definitely switch players from team chat to observer chat at some point, though.

[Micr0Bit]

true

[pchote]

The defeated team-mate case is best solved by #3210:

• If a player is on a team with at least one active player, then use the team-spec mode (no vis controls, regular team chat)
• If a player is not on a team, or everyone in their team is defeated then they all drop to the full spec mode (vis controls, spec chat).

[obrakmann]

👍 works as advertised. As team-chat already doesn't work for dead players and cheating is thus not possible, I won't hold this up to require that dead players get switched to spec chat as well. #3210 indeed sounds like a better solution to that problem.

[obrakmann]

Changelog