Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix for missiles launched from zero height #9646

Merged
merged 1 commit into from Oct 20, 2015

Conversation

matija-hustic
Copy link
Contributor

Fixes choosing minimum launch speed for missiles launched at or below terrain height.

Takes care of #9645.

@pchote pchote added this to the Next release milestone Oct 17, 2015
@reaperrr
Copy link
Contributor

👍

@obrakmann
Copy link
Contributor

👍

obrakmann added a commit that referenced this pull request Oct 20, 2015
Temporary fix for missiles launched from zero height
@obrakmann obrakmann merged commit a547f55 into OpenRA:bleed Oct 20, 2015
@obrakmann
Copy link
Contributor

Changelog

@matija-hustic matija-hustic deleted the missile_fixup branch October 21, 2015 00:43
@obrakmann
Copy link
Contributor

It looks like this broke torpedoes while fixing TD's SAMs.

@matija-hustic
Copy link
Contributor Author

Nah, just checked it, it has been broken ever since the original PR. It's still that explosion height check. I haven't set it back to strictly less to zero. Now I'll file yet another PR :/ The follow up is not quite done yet...
In the meantime - is there an issue open for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants