Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash in the install logic #57

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

abcdefg30
Copy link
Member

Fixes #55.

Results in this now:
ra2fetchassets

also installs THEME.mix now.
@abcdefg30
Copy link
Member Author

I just found out, that we can support installing the music (THEME.mix) from CD by changing the order of ExtractFilesFromCD (as THEME.mix is located in the main directory, not inside of the CAB). Updated.

@Mailaender
Copy link
Member

You have to use CopyFilesFromCD for that. Example: https://github.com/OpenRA/OpenRA/blob/bleed/mods/d2k/mod.yaml#L142

@abcdefg30
Copy link
Member Author

Huh, I tested it with the current setup and it worked.

@Mailaender
Copy link
Member

I guess it works, because everything is mounted and the game can't differentiate folder and CAB. If it fixes the crash and it copies at least the music this is one step forward. 👍

Mailaender added a commit that referenced this pull request Jan 19, 2016
Fix a crash in the install logic
@Mailaender Mailaender merged commit e7bb096 into OpenRA:master Jan 19, 2016
@abcdefg30 abcdefg30 deleted the installPackage branch January 19, 2016 18:58
Mailaender added a commit that referenced this pull request May 19, 2016
Fix a crash in the install logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants