Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dogs not dealing damage and removed veterancy #661

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Fixed dogs not dealing damage and removed veterancy #661

merged 2 commits into from
Mar 15, 2020

Conversation

Mailaender
Copy link
Member

@Mailaender Mailaender commented Mar 15, 2020 •
edited
Loading

Closes #623.
Closes #402.

sorcerer86pt
sorcerer86pt suggested changes Mar 15, 2020
View reviewed changes
Copy link

@sorcerer86pt sorcerer86pt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this review should be renamed: Who let the dogs out :-)

Dogs now attack as they should. The animations is quite quick, and the range is a little big. I will put a video of them attacking

@Mailaender Mailaender changed the title Fixed dogs not dealing damage Fixed dogs not dealing damage and removed veterancy Mar 15, 2020
sorcerer86pt
sorcerer86pt approved these changes Mar 15, 2020
View reviewed changes
Copy link

@sorcerer86pt sorcerer86pt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mailaender Mailaender merged commit 50943de into OpenRA:master Mar 15, 2020
@Mailaender Mailaender deleted the dogs branch March 15, 2020 19:38
@MustaphaTR
Copy link
Member

I was about to comment,

Can you move the Inherits: ^GainsExperience to each actor that gains XP specifically instead of removing all these here. There are more than dogs that shouldn't be able to gain XP.

for the veterancy changes. But you merged before i could. It looks weird with so many removals for one thing.

@Mailaender
Copy link
Member Author

Sorry for being too quick. I also thought about it. Our setup is a bit weird that dogs are infantry after all. This indeed might need a cleanup.

@MustaphaTR
Copy link
Member

^GainsExperience is being defined on each actor, instead of defaults, on upstream for a good while now. That's also the case in RV.

@MustaphaTR MustaphaTR mentioned this pull request Mar 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorcerer86pt sorcerer86pt sorcerer86pt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

attack dogs are at the moment useless Attack dogs get veteran or elite
3 participants
@Mailaender @MustaphaTR @sorcerer86pt