openrc: avoid unnecessary malloc inside sig-handler #590
Conversation
|
Since there's interest in fixing the sig-handler issue - I plan on fixing and submitting the fixes one at a time. But if one large PR is preferred instead - let me know and I can do that too. |
|
agreed that this is def not fixed, and we can't use errorx for a bunch of reasons (fprintf/syslog), but this prob is marginally better by not directly diving into the memory allocator |
|
Bit frustrated there's no annotations for this class of problem other than IIRC Valgrind being able to detect it at runtime (I don't recall if any of the sanitizers can). Someone laid out the general recipe at https://news.ycombinator.com/item?id=16754394, not that it went anywhere. |
|
N-R-K
force-pushed
the
rm_asprintf
branch
2 times, most recently
from
6e0e3f1
to
83bba03
Compare
malloc (called by xasprintf) is not async-signal-safe. beside, the string here is constant, so there's no need to malloc it all. eerrorx isn't async-signal-safe either (due to calling fprintf and exit) but consequence of them are _typically_ not as grave as calling malloc while it's internal state is inconsistent. Bug: OpenRC#589
|
thx bud |
malloc (called by xasprintf) is not async-signal-safe. beside, the string here is constant, so there's no need to malloc it all.
eerrorx isn't async-signal-safe either (due to calling fprintf and exit) but consequence of them are typically not as grave as calling malloc while it's internal state is inconsistent.
Bug: #589