-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use macos-14 workers to create libraries #42
Conversation
The macos-14 is already arm-based image
Can we work around the vcpkg libpng issue, somehow? Does it present itself if we do not update the pinned vcpkg commit hash, for example? |
It's still present in older vcpkg. I'll look into that |
Note: this only happens in our custom triplet. Using arm64 host to build amd64 package with vcpkg's own triplet works ok. |
what is special about our triplet? |
We link statically, vcpkg prefers dynamic linking Edit: or the other way round ¯\_(ツ)_/¯ |
So it was a one-line fix in the triplet, in the end? Nice work! |
82dde58
to
44c1e74
Compare
Yeah, it was just that line missing. Once this is approved & merged, I still need to push a tag for new release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. Haven't tested the resulting dep bundle, but that can be done once it is hooked up to the OpenRCT2 CI. Could you amend OpenRCT2/OpenRCT2#22601 to that end?
The macos-14 is already arm-based image