Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ISSUE 2866 #2867

Merged
merged 3 commits into from
Jul 1, 2024
Merged

fix for ISSUE 2866 #2867

merged 3 commits into from
Jul 1, 2024

Conversation

yanleiberg
Copy link
Contributor

@yanleiberg yanleiberg commented Jun 28, 2024

Applying fix for issue(s):

Add extra pair of {POP16}{PUSH16} in STR_2386 for zh_cn, zh_tw, ja-JP.
Removed {NEWLINE} in STR_2386 for zh_cn for better layout.
Add "底" (meaning "the end of" a month) in STR_2386 and STR_2387 to avoid ambiguity in current string, as it isn't currently indicating whether the goal is for the beginning or the end of a month.

fix for OpenRCT2#2866
wrong MONTHYEAR in the goal description for ja-JP.
fix for OpenRCT2#2866
wrong MONTHYEAR in the goal description for zh-TW
fix for OpenRCT2#2866
- wrong MONTHYEAR in the goal description for zh-CN
- remove {NEWLINE} for better layout
- add "底" (meaning "the end of" a month) to STR_2386 and STR_2387 to avoid confusions meaning.
Copy link

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ja-JP 351 1 607
zh-CN 0 1 35
zh-TW 168 0 333

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 116 2 1913
ca-ES 0 1 123
cs-CZ 435 0 248
da-DK 25 0 564
de-DE 0 1 358
en-US 3397 0 392
eo-ZZ 0 1 91
es-ES 0 1 306
fi-FI 6 1 117
fr-CA 3982 0 0
fr-FR 4 1 167
hu-HU 0 0 122
it-IT 3 1 346
ko-KR 0 1 196
nb-NO 25 0 483
nl-NL 0 13 480
pl-PL 193 1 408
pt-BR 0 1 150
ru-RU 1357 0 111
sv-SE 108 1 353
tr-TR 414 1 382
uk-UA 35 34 1139
vi-VN 273 3 3226

@Gymnasiast Gymnasiast merged commit 38b9753 into OpenRCT2:master Jul 1, 2024
1 check passed
@Gymnasiast
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants