Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Air powered coaster train's front car not imported properly in RCT1 parks #17337

Closed
ZeeMaji opened this issue Jun 5, 2022 · 0 comments · Fixed by #17338
Closed

Air powered coaster train's front car not imported properly in RCT1 parks #17337

ZeeMaji opened this issue Jun 5, 2022 · 0 comments · Fixed by #17338
Labels
bug Something went wrong.

Comments

@ZeeMaji
Copy link
Contributor

ZeeMaji commented Jun 5, 2022

Operating System

Linux (OpenSUSE Tumbleweed)

OpenRCT2 build

OpenRCT2, v0.4.0

Describe the issue

When importing RCT1 parks with the air powered coaster in them it's train's front car is not imported properly, see attachments.

Area(s) with issue?

No response

Steps to reproduce

  1. Open an RCT1 park with an air powered coaster in it
  2. Go over to it and investigate
  3. It's front car isn't the proper variant

Attachments

RCT1
DeepinScreenshot_select-area_20220605154137
OpenRCT2
DeepinScreenshot_select-area_20220605154302

Here is an original RCT1 save file to use for testing this.
airpowered.SV4.tar.gz
@ZeeMaji ZeeMaji added the bug Something went wrong. label Jun 5, 2022
Gymnasiast added a commit to Gymnasiast/OpenRCT2 that referenced this issue Jun 5, 2022
@Gymnasiast
Fix OpenRCT2#17337: APVC trains not imported properly when loading RC…
218be2e 
…T1 parks
@Gymnasiast Gymnasiast linked a pull request Jun 5, 2022 that will close this issue
Fix #17337: APVC trains not imported properly when loading RCT1 parks #17338
Merged
Gymnasiast added a commit that referenced this issue Jun 5, 2022
@Gymnasiast
Fix #17337: APVC trains not imported properly when loading RCT1 parks
60659f4
karst added a commit to karst/OpenRCT2 that referenced this issue Jun 6, 2022
@karst
Squashed commit of the following:
628f7c0 
commit 5478553
Author: Karst <karstvangalenlast@gmail.com>
Date:   Mon Jun 6 21:52:47 2022 +0200

    Update Shields in Readme

commit 0791b22
Author: frutiemax <lucas.malo.belanger@gmail.com>
Date:   Mon Jun 6 15:00:16 2022 -0400

    Add MusicUpdateFunction field to RTD

commit 4b11a4f
Author: X123M3-256 <X123M3-256@users.noreply.github.com>
Date:   Mon Jun 6 19:10:56 2022 +0100

    Remove incorrect flags from alpine coaster (OpenRCT2#17347)

commit 88b3e88
Author: Michael Steenbeek <m.o.steenbeek@gmail.com>
Date:   Mon Jun 6 10:07:07 2022 +0200

    Remove Testpaint (OpenRCT2#17333)

    TestPaint served us well, but it hasn’t compiled for years, and before that it produced incorrect results for years.

commit e9c749d
Author: OpenRCT2 git bot <gitbot@openrct2.org>
Date:   Mon Jun 6 04:08:45 2022 +0000

    Merge Localisation/master into OpenRCT2/develop

commit 3243183
Author: Michael Steenbeek <m.o.steenbeek@gmail.com>
Date:   Mon Jun 6 00:11:29 2022 +0200

    Fix OpenRCT2#17187: Text input window does not resize correctly

    window_set_resize() already invalidates, so no need to call it twice.

    Co-authored-by: guljam <guljam@users.noreply.github.com>

commit 60659f4
Author: Michael Steenbeek <m.o.steenbeek@gmail.com>
Date:   Sun Jun 5 23:19:35 2022 +0200

    Fix OpenRCT2#17337: APVC trains not imported properly when loading RCT1 parks

commit 29bcd0d
Author: Sadret <stephanspengler93@gmail.com>
Date:   Sun Jun 5 21:05:51 2022 +0200

    Fix OpenRCT2#17335: plugin docs now show correct type for PixelData 'data' attribute

commit d1d1a85
Merge: 339edcd 5592e88
Author: Hielke Morsink <hielke.morsink@gmail.com>
Date:   Sun Jun 5 18:41:57 2022 +0200

    Merge pull request OpenRCT2#17328

commit 5592e88
Author: Hielke Morsink <hielke.morsink@gmail.com>
Date:   Sun Jun 5 09:53:25 2022 +0200

    Add changelog entry

commit 6d04e21
Author: Hielke Morsink <hielke.morsink@gmail.com>
Date:   Sun Jun 5 00:25:00 2022 +0200

    Make map size spinners in mapgen window functional

commit 339edcd
Author: Michael Steenbeek <m.o.steenbeek@gmail.com>
Date:   Sun Jun 5 09:40:53 2022 +0200

    Fix OpenRCT2#17310: Reversed reversible vehicles not imported properly from S4

commit 7f2f27e
Author: Hielke Morsink <hielke.morsink@gmail.com>
Date:   Sat Jun 4 23:22:42 2022 +0200

    Show map size inside spinner widgets

commit 49c3f49
Author: Hielke Morsink <hielke.morsink@gmail.com>
Date:   Sat Jun 4 19:56:31 2022 +0200

    Split X and Y size in mapgen logic

commit 1644cb6
Author: Hielke Morsink <hielke.morsink@gmail.com>
Date:   Sat May 21 08:59:23 2022 +0200

    Split X and Y map size spinners in mapgen

commit 8d14016
Author: Hielke Morsink <hielke.morsink@gmail.com>
Date:   Sun May 15 22:25:45 2022 +0200

    Allow maps to be resized to non-rectangular shapes

commit 673ec0f
Author: spacek531 <spacek531@comcast.net>
Date:   Fri Jun 3 15:03:02 2022 -0700

    Frames rotation count part 1 (OpenRCT2#17106)

    Refactor vehicle sprite groups

    rename rotationType to spriteGroup

    remove numframes getters from scobject

    add sprite groups getters

    add documentation to plugin

    Co-authored-by: duncanspumpkin <duncans_pumpkin@hotmail.co.uk>
Gymnasiast added a commit that referenced this issue Jul 4, 2022
@Gymnasiast
Release v0.4.1
be518f4 
- Feature: [#16825] Add Alpine Coaster track type.
- Feature: [#17011] Option to show ride vehicles as separate entries when selecting a ride to construct.
- Feature: [#17217] Add FLAC and OGG/vorbis as supported audio formats for ride music objects.
- Feature: [#12328, #17418] Add vehicles for the Hybrid Coaster, Single-Rail Roller Coaster and Classic Mini Roller Coaster.
- Improved: [#7983] The red colour in the ride stat screen and the ride graphs now corresponds better to negative effects on a ride’s stats.
- Improved: [#13966] Music Style dropdown is now sorted by name.
- Improved: [#16978] Tree placement is more natural during map generation.
- Improved: [#16992] The checkbox in the visibility column of the Tile Inspector has been replaced with an eye symbol.
- Improved: [#16999] The maximum price for the park entry has been raised to £999.
- Improved: [#17050] Transparency can be enabled directly without needing see-through enabled first.
- Improved: [#17059] Show Tile Inspector usage hint when nothing is selected.
- Improved: [#17199] Allow creation of Spiral Slide reskins.
- Improved: [#17242] More natural looking shorelines in map generator.
- Improved: [#17328] Parks can now be resized into rectangular shapes from the map and map generation windows.
- Change: [#16952] Make “Object Selection” order more coherent.
- Change: [#17002] Weather no longer resets when converting a save to scenario.
- Change: [#17294] New ride window remembers scroll position per tab instead of highlighted ride.
- Removed: [#16864] Title sequence editor (replaced by plug-in).
- Removed: [#16911, #17411] Residual support for pre-Vista Windows systems.
- Fix: [#13997] Placing a track design interferes with other players building a ride.
- Fix: [#15787] When deselecting "Show banner text in upper case", the banners remain upper case for 10 seconds.
- Fix: [#16539] CustomListView header not clickable when listview is scrolled.
- Fix: [#16799] Browsing “Up” in the Load Save window shows no files, only folders.
- Fix: [#16934] Park size displayed incorrectly in Park window.
- Fix: [#16974] Small scenery ghosts can be deleted.
- Fix: [#16989] Re-focusing maximised window triggers a restore and maximise.
- Fix: [#17005] Unable to set patrol area for first staff member in park.
- Fix: [#17017] [Plugin] Crash when using tile element properties that require a valid ride to be linked.
- Fix: [#17073] Corrupt ride window and random crashes when trains have more than 144 cars.
- Fix: [#17080] “Remove litter” cheat does not empty litter bins.
- Fix: [#17099] Object selection thumbnail box is one pixel too tall.
- Fix: [#17104] Changing map size does not invalidate park size.
- Fix: [#17157] Crash when browsing “Up” to folder with CJK characters in its name.
- Fix: [#17187] Text input window does not resize correctly.
- Fix: [#17197] Segfault when extracting files from the GOG installer.
- Fix: [#17205] Map generator sometimes crashes when not all standard terrain objects are available.
- Fix: [#17221] Object ghosts and tooltips follow invisible cursor when moving the viewport by right-click dragging.
- Fix: [#17255] Cursor position is incorrect when adjusting terrain and water height.
- Fix: [#17257] [Plugin] Add tertiary colour to large scenery scripting API.
- Fix: [#17261] Hand cursor position is incorrect when dragging items in the Inventions List window.
- Fix: [#17292] Rows in shortcut key list stay highlighted when cursor leaves list.
- Fix: [#17295] Pause status not cleared when loading a scenario made from a converted paused save.
- Fix: [#17310] Reversed reversible vehicles not imported properly when loading RCT1 parks.
- Fix: [#17335] [Plugin] Documentation has an incorrect type for PixelData ‘data’ attribute.
- Fix: [#17337] Air Powered Vertical Coaster trains not imported properly when loading RCT1 parks.
- Fix: [#17346] Surface height markers are concealed by sprites of same surface.
- Fix: [#17369] [Plugin] ‘Car.travelBy()’ moves other cars as well.
- Fix: [#17377] When building the park entrance before opening the Footpaths window, the path will be invisible.
- Fix: [#17381] Air Powered Vertical Coaster stat penalty is wrong.
- Fix: [#17399] Guests never generate the being watched thought.
- Fix: [#17433] Wrong T-shirt colours for guests on a Twist ride.
- Fix: [#17450] Ducks can swim on three-corners-up land tile.
- Fix: [#17461] Footpath Railing tooltip showing incorrect tooltip.
- Fix: [#17464] Green Tarmac footpath is not available in the Track Designer.
- Fix: [#17466] New object types not packed in save files.
- Fix: [#17481] Roto-drop cars try going up to top pieces that are ghosts or belong to other rides.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something went wrong.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #17337: APVC trains not imported properly when loading RCT1 parks Gymnasiast/OpenRCT2
1 participant
@ZeeMaji