Move gBankLoan and gBankLoanInterestRate to GameState_t

[Martymoose98]

Move gBankLoan and gBankLoanInterestRate to GameState_t for #21193

[Gymnasiast]

Code looks good. Branch will have to be squashed and the commit message rewritten, be we can do that on merging, especially since you’re a first-time contributor.

[Martymoose98]

Yeah I forgot to format the commit message on the subsequent commits. I think the first commit message passed but the format failed so I was anxious to fix the format check. Is there a way I could have the format checks on my fork? Additionally, I could do some other global vars if you want.

[Gymnasiast]

We use clang-format. This command should be available in git, like this:

git add -A
git clang-format
git add -A # Re-add the files that were formatted in the previous step

The failing commit-lint is because of your merge commit - we always rebase branches if they get out of sync with develop.

Also, better to just stick to the two vars you already did in this PR.

[Martymoose98]

I don't seem to have git clang-format. I'm not the greatest with git 😞.
Rebase worked however I think I did that correctly?
Also, I don't know why it's added the recent localization file changes. :/
I think I have to rebase again cause of the recent pushes to develop?
I'm sorry if I'm getting in the way because of my git inability. ( I don't usually use git this extensively, this is the first time i used git rebase -i HEAD~4)

So is there something else I could do to help?

[Gymnasiast]

You would normally use git rebase -i upstream/develop (assuming you have our repository as "upstream"). There is still a merge commit, but I wouldn’t worry too much about it - we’ll just squash the lot.

[Martymoose98]

Alright, I'll remember that git command for the future.

[Gymnasiast]

Good. Remember that you can always ask us here or on Discord if you get stuck.