Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic extension methods to AspCore services and pipline #413

Merged
merged 6 commits into from
May 9, 2023
Merged

Conversation

ehsangfl
Copy link
Contributor

@ehsangfl ehsangfl commented May 6, 2023

No description provided.

@ehsangfl ehsangfl changed the title Add generic methods to AspCore routing amd mapping Add generic methods to AspCore routing and mapping May 6, 2023
@ehsangfl ehsangfl changed the title Add generic methods to AspCore routing and mapping Add generic extendsion methods to AspCore routing and mapping May 6, 2023
@Daniel-Svensson
Copy link
Member

Daniel-Svensson commented May 6, 2023

Looks good to me can @OpenRIAServices/openriaservices or @SandstromErik have a look and merge it if fine.

it would be good to add a line to the changelog.md in the root

@ehsangfl ehsangfl changed the title Add generic extendsion methods to AspCore routing and mapping Add generic extendsion methods to AspCore routing and pipline May 7, 2023
@ehsangfl ehsangfl changed the title Add generic extendsion methods to AspCore routing and pipline Add generic extendsion methods to AspCore services and pipline May 7, 2023
Copy link
Contributor

@SandstromErik SandstromErik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only missing an 'e' in changelog

Changelog.md Outdated Show resolved Hide resolved
@Daniel-Svensson Daniel-Svensson changed the title Add generic extendsion methods to AspCore services and pipline Add generic extension methods to AspCore services and pipline May 9, 2023
@SandstromErik
Copy link
Contributor

@ehsangfl Thank you for the contribution, it is very appreciated!

@SandstromErik SandstromErik enabled auto-merge (squash) May 9, 2023 14:55
@sonarcloud
Copy link

sonarcloud bot commented May 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@SandstromErik SandstromErik merged commit 49c07ef into OpenRIAServices:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants