Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update module, buffer and driver for off-policy algorithm #74

Merged
merged 1 commit into from
May 19, 2023

Conversation

YiwenAI
Copy link
Collaborator

@YiwenAI YiwenAI commented May 19, 2023

Description

update module, buffer and driver for off-policy algorithm

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have ensured make test pass (required).
  • I have checked the code using make commit-checks (required).

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #74 (78927d9) into main (e2cfb87) will decrease coverage by 0.61%.
The diff coverage is 1.31%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   41.28%   40.68%   -0.61%     
==========================================
  Files         124      124              
  Lines        7671     7777     +106     
==========================================
- Hits         3167     3164       -3     
- Misses       4504     4613     +109     
Flag Coverage Δ
unittests 40.68% <1.31%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openrl/buffers/offpolicy_buffer.py 0.00% <0.00%> (ø)
openrl/buffers/offpolicy_replay_data.py 0.00% <0.00%> (ø)
openrl/drivers/offpolicy_driver.py 24.61% <0.00%> (-1.10%) ⬇️
openrl/modules/dqn_module.py 58.53% <0.00%> (ø)
openrl/runners/common/dqn_agent.py 56.66% <ø> (ø)
openrl/algorithms/dqn.py 19.00% <5.00%> (-4.26%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@huangshiyu13 huangshiyu13 merged commit 3905631 into OpenRL-Lab:main May 19, 2023
@huangshiyu13 huangshiyu13 mentioned this pull request May 19, 2023
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants