Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse cuts out at full power #239

Closed
BrianAdams opened this issue Jun 16, 2014 · 5 comments
Closed

Reverse cuts out at full power #239

BrianAdams opened this issue Jun 16, 2014 · 5 comments
Labels
Milestone

Comments

@BrianAdams
Copy link
Contributor

Workaround is to stay in power level 4. The root issue is that the current system is trying to create a linear thrust model of the motors which requires doubling the rpm's of the motor in reverse. The system does not guard that the target servo value can be outside the response range of the ESC.

@BrianAdams BrianAdams added this to the vNext milestone Jun 16, 2014
@BrianAdams BrianAdams added the bug label Jun 16, 2014
@vamfun
Copy link

vamfun commented Jun 19, 2014

Brian. Can u point to the file that needs fixing. I need to make the changes in the next few days. I will do my own testing and patches if I know where the problem code lines are. Also I think limiting to level 4 is ok except the diagnostic inputs will still go to zero on full reverse won't they?

@BrianAdams
Copy link
Contributor Author

@vamfun, you are correct about the diagnostics. The change needs to be made in the motors.cpp file in the Arduino code. You will see that it multiplies the target thrust by Motor_Negative_Modifiers (these are the ones causing the issues since they are set to 2). It needs a limit after that calculation to that the resulting value stays above 1000. ( The range on the ESC is 1000-2000ms).

@vamfun
Copy link

vamfun commented Jun 20, 2014

Posted my quick fix here.
http://openrov.com/xn/detail/6365107:Comment:92456

@vamfun
Copy link

vamfun commented Jun 23, 2014

Txs again, u saw my fix that I posted.

I need a few hints on how to manage the capture pictures , ie delete , bulk copy or xfer...

I am delivering the ROV to Algalita tomorrow and would like to give them instructions on how to use capture function.

Thanks again , I know u have a full plate.

Sent from my iPhone

On Jun 19, 2014, at 9:03 AM, badevguru notifications@github.com wrote:

@vamfun, you are correct about the diagnostics. The change needs to be made in the motors.cpp file in the Arduino code. You will see that it multiplies the target thrust by Motor_Negative_Modifiers (these are the ones causing the issues since they are set to 2). It needs a limit after that calculation to that the resulting value stays above 1000. ( The range on the ESC is 1000-2000ms).


Reply to this email directly or view it on GitHub.

@BrianAdams
Copy link
Contributor Author

http://openrov.com/xn/detail/6365107:Comment:92815

On Mon, Jun 23, 2014 at 8:43 AM, vamfun notifications@github.com wrote:

Txs again, u saw my fix that I posted.

I need a few hints on how to manage the capture pictures , ie delete ,
bulk copy or xfer...

I am delivering the ROV to Algalita tomorrow and would like to give them
instructions on how to use capture function.

Thanks again , I know u have a full plate.

Sent from my iPhone

On Jun 19, 2014, at 9:03 AM, badevguru notifications@github.com wrote:

@vamfun, you are correct about the diagnostics. The change needs to be
made in the motors.cpp file in the Arduino code. You will see that it
multiplies the target thrust by Motor_Negative_Modifiers (these are the
ones causing the issues since they are set to 2). It needs a limit after
that calculation to that the resulting value stays above 1000. ( The range
on the ESC is 1000-2000ms).


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#239 (comment)
.

BrianAdams added a commit that referenced this issue Jun 23, 2014
BrianAdams added a commit that referenced this issue Jul 3, 2015
codewithpassion pushed a commit to codewithpassion/openrov-software that referenced this issue Jul 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants