Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSV2 : inserted input are not displayed in the table #8019

Closed
bgiuliana opened this issue Jul 11, 2024 · 0 comments · Fixed by #8032
Closed

TSV2 : inserted input are not displayed in the table #8019

bgiuliana opened this issue Jul 11, 2024 · 0 comments · Fixed by #8032
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:critical Critical severity bug

Comments

@bgiuliana
Copy link
Contributor

What happened?

We create a train. We try to enter some input values (arrival time, stopping time or theoretical margin). These values are not displayed on the table altought they are used in the calculation. If we look at simulation results, the values are taken into account.
If we edit the train, the input table is still empty. Sometimes, we manage to get the values ​​by reloading the page or if we try to create another train.

What did you expect to happen?

The values should be displayed

How can we reproduce it (as minimally and precisely as possible)?

Go to a scenario TSV2
Add a train
Go to times and stops table
Put a margin value for example

What operating system, browser and environment are you using?

  • Browser: Edge
  • OS: Windows
  • Env: Recette

OSRD version (top right corner Account button > Informations)

staging de8ada8

@bgiuliana bgiuliana added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules severity:critical Critical severity bug labels Jul 11, 2024
@emersion emersion assigned emersion and unassigned SharglutDev Jul 11, 2024
emersion added a commit that referenced this issue Jul 11, 2024
The function was trying to compare path steps IDs and OP IDs. These
will never match, since they are different object types. Instead,
add a helper function to match the OP ID, UIC or trigram and use it.

isMarginValid looked at op.theoreticalMargin, but never took the
path step (if any) into account. The opposite was done for
stopFor and theoreticalMargin: these were always extracted from
the path step, never from the OP.

Closes: #8019
emersion added a commit that referenced this issue Jul 11, 2024
The function was trying to compare path steps IDs and OP IDs. These
will never match, since they are different object types. Instead,
add a helper function to match the OP ID, UIC or trigram and use it.

isMarginValid looked at op.theoreticalMargin, but never took the
path step (if any) into account. The opposite was done for
stopFor and theoreticalMargin: these were always extracted from
the path step, never from the OP.

Closes: #8019
emersion added a commit that referenced this issue Jul 12, 2024
The function was trying to compare path steps IDs and OP IDs. These
will never match, since they are different object types. Instead,
add a helper function to match the OP ID, UIC or trigram and use it.

isMarginValid looked at op.theoreticalMargin, but never took the
path step (if any) into account. The opposite was done for
stopFor and theoreticalMargin: these were always extracted from
the path step, never from the OP.

Closes: #8019
github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
The function was trying to compare path steps IDs and OP IDs. These
will never match, since they are different object types. Instead,
add a helper function to match the OP ID, UIC or trigram and use it.

isMarginValid looked at op.theoreticalMargin, but never took the
path step (if any) into account. The opposite was done for
stopFor and theoreticalMargin: these were always extracted from
the path step, never from the OP.

Closes: #8019
@Maymanaf Maymanaf self-assigned this Jul 18, 2024
Math-R pushed a commit that referenced this issue Jul 18, 2024
The function was trying to compare path steps IDs and OP IDs. These
will never match, since they are different object types. Instead,
add a helper function to match the OP ID, UIC or trigram and use it.

isMarginValid looked at op.theoreticalMargin, but never took the
path step (if any) into account. The opposite was done for
stopFor and theoreticalMargin: these were always extracted from
the path step, never from the OP.

Closes: #8019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:critical Critical severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants