Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: Fix reset button in Space Speed chart #2846

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

Uriel-Sautron
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron commented Jan 11, 2023

close #2836

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner January 11, 2023 10:37
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #2846 (15c58f8) into dev (7436a8f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #2846      +/-   ##
============================================
- Coverage     38.06%   38.06%   -0.01%     
  Complexity     1701     1701              
============================================
  Files           585      585              
  Lines         18010    18013       +3     
  Branches       2486     2486              
============================================
  Hits           6856     6856              
- Misses        10755    10758       +3     
  Partials        399      399              
Flag Coverage Δ
front 4.12% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ents/Simulation/SpeedSpaceChart/SpeedSpaceChart.js 0.00% <0.00%> (ø)
...components/Simulation/SpeedSpaceChart/d3Helpers.js 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…Effect in componnets/Simulation/SpeedSpaceChart/SpeedSpaceChart.js to call the function resetChartToggle when the restart state is changed
@Uriel-Sautron Uriel-Sautron force-pushed the usn/fix-reset-button-space-speed-graph branch from dc15906 to 15c58f8 Compare January 13, 2023 15:12
@anisometropie anisometropie merged commit 92baa89 into dev Jan 17, 2023
@anisometropie anisometropie deleted the usn/fix-reset-button-space-speed-graph branch January 17, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The graph display reset button does not work for the space-speed graph
2 participants