Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump diesel to 2.0 #2873

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Bump diesel to 2.0 #2873

merged 1 commit into from
Jan 13, 2023

Conversation

leovalais
Copy link
Contributor

Rocket has not released Diesel 2.0 support on crates.io yet.
I also bumped rocket_cors' rev (no breaking change).

Closes #2862

@leovalais leovalais requested a review from a team as a code owner January 12, 2023 17:26
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #2873 (fd0b19a) into dev (f69af4d) will increase coverage by 0.01%.
The diff coverage is 76.92%.

@@             Coverage Diff              @@
##                dev    #2873      +/-   ##
============================================
+ Coverage     37.86%   37.87%   +0.01%     
  Complexity     1693     1693              
============================================
  Files           584      584              
  Lines         17899    17899              
  Branches       2471     2471              
============================================
+ Hits           6777     6779       +2     
+ Misses        10725    10723       -2     
  Partials        397      397              
Flag Coverage Δ
editoast 72.42% <76.92%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/generated_data/error/mod.rs 70.58% <ø> (ø)
editoast/src/schema/buffer_stop.rs 78.57% <ø> (ø)
editoast/src/schema/detector.rs 78.57% <ø> (ø)
editoast/src/schema/operation/create.rs 97.43% <ø> (ø)
editoast/src/schema/operation/mod.rs 33.33% <ø> (ø)
editoast/src/schema/operation/update.rs 62.06% <ø> (ø)
editoast/src/schema/signal.rs 78.57% <ø> (ø)
editoast/src/views/infra/edition.rs 96.29% <ø> (ø)
editoast/src/views/infra/errors.rs 75.51% <ø> (ø)
editoast/src/views/infra/mod.rs 98.18% <ø> (ø)
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I think we should really consider stop using rocket.

editoast/Cargo.toml Outdated Show resolved Hide resolved
@flomonster flomonster merged commit 44aa931 into dev Jan 13, 2023
@flomonster flomonster deleted the lva/diesel-2.0 branch January 13, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade diesel to 2.0
3 participants