front: Fix cartography sub windows #2876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #2876 +/- ##
============================================
+ Coverage 40.48% 40.68% +0.19%
Complexity 1711 1711
============================================
Files 630 634 +4
Lines 18805 18724 -81
Branches 2360 2346 -14
============================================
+ Hits 7614 7618 +4
+ Misses 10777 10692 -85
Partials 414 414
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Uriel-Sautron
force-pushed
the
usn/fix-cartography-sub-windows
branch
from
3f603ea
to
266b7ba
Compare
Uriel-Sautron
force-pushed
the
usn/fix-cartography-sub-windows
branch
from
266b7ba
to
be01bfc
Compare
|
Even if there is no conflict, could you rebase? It's hard to test. Thank you |
Uriel-Sautron
force-pushed
the
usn/fix-cartography-sub-windows
branch
from
4b557d5
to
1bcc2c8
Compare
|
Rebase done but work to replace eventListener in MapButton.js |
Uriel-Sautron
force-pushed
the
usn/fix-cartography-sub-windows
branch
from
1bcc2c8
to
abf9c1f
Compare
|
Create custom hook useOutsideClick to use in MapButtons. |
clarani
requested changes
Feb 17, 2023
There was a problem hiding this comment.
Nice job ! I have left several comments.
I think the modals (or popovers) do not need to have active in their props, since they should not be displayed if they are not active. Some refacto can be done if you remove active of each component (MapSearch, MapSettings, MapKey)
…s, MapSearch.js, MapSettings.js
… close modal by click outside. Use dispatch to close pop-up map when a modal opens
…ive and replace x for ×. MapButton: use conditional rendering for popup. Map.scss: in .map-modal remove opacity: 0 and change z-index to 1
…ps. MapKey: add HeaderPopUp and remove button bottom right
Uriel-Sautron
force-pushed
the
usn/fix-cartography-sub-windows
branch
from
fd495ba
to
80495f0
Compare
clarani
requested changes
Feb 17, 2023
anisometropie
requested changes
Feb 17, 2023
...ions/operationalStudies/components/ManageTrainSchedule/ManageTrainScheduleMap/RenderPopup.js
Outdated
Show resolved
Hide resolved
…gs: change function name. Map.scss: remove active in map-modal class
… modal and an useEffect to close the map popup
anisometropie
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2831