Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edition #2897

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Fix edition #2897

merged 2 commits into from
Jan 16, 2023

Conversation

flomonster
Copy link
Contributor

An error occured when generating lpvpanellayer due to an error in the table model.

I also used disel dsl for more safety.

@flomonster flomonster requested a review from a team as a code owner January 16, 2023 11:20
@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Merging #2897 (980f4d7) into dev (6952594) will increase coverage by 0.12%.
The diff coverage is 37.93%.

@@             Coverage Diff              @@
##                dev    #2897      +/-   ##
============================================
+ Coverage     38.17%   38.29%   +0.12%     
  Complexity     1701     1701              
============================================
  Files           587      587              
  Lines         18054    18047       -7     
  Branches       2486     2486              
============================================
+ Hits           6893     6912      +19     
+ Misses        10762    10736      -26     
  Partials        399      399              
Flag Coverage Δ
editoast 73.33% <37.93%> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/generated_data/buffer_stop.rs 50.00% <0.00%> (+2.63%) ⬆️
editoast/src/generated_data/detector.rs 50.00% <0.00%> (+2.63%) ⬆️
editoast/src/generated_data/operational_point.rs 45.00% <0.00%> (+2.14%) ⬆️
editoast/src/generated_data/signal.rs 50.00% <0.00%> (+2.63%) ⬆️
editoast/src/generated_data/track_section.rs 50.00% <0.00%> (+2.63%) ⬆️
editoast/src/generated_data/track_section_link.rs 50.00% <0.00%> (+2.63%) ⬆️
editoast/src/generated_data/catenary.rs 85.00% <100.00%> (-0.72%) ⬇️
editoast/src/generated_data/lpv_panel.rs 86.36% <100.00%> (+10.17%) ⬆️
editoast/src/generated_data/speed_section.rs 85.00% <100.00%> (-0.72%) ⬇️
editoast/src/schema/operation/mod.rs 26.66% <0.00%> (-6.67%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@flomonster flomonster merged commit acc6f01 into dev Jan 16, 2023
@flomonster flomonster deleted the fam/fix-edition branch January 16, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants