Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: add a duplicate infra endpoint to editoast #2998

Merged
merged 1 commit into from
Feb 9, 2023
Merged

editoast: add a duplicate infra endpoint to editoast #2998

merged 1 commit into from
Feb 9, 2023

Conversation

majaziri
Copy link
Contributor

@majaziri majaziri commented Jan 26, 2023 •
edited by axrolld
Loading

Closes #1840

@majaziri majaziri requested a review from a team as a code owner January 26, 2023 12:17
@codecov
Copy link

codecov bot commented Feb 1, 2023 •
edited
Loading

Codecov Report

Merging #2998 (ee9484d) into dev (46306e0) will increase coverage by 0.17%.
The diff coverage is 93.18%.

@@             Coverage Diff              @@
##                dev    #2998      +/-   ##
============================================
+ Coverage     38.69%   38.86%   +0.17%     
  Complexity     1709     1709              
============================================
  Files           603      603              
  Lines         18747    18791      +44     
  Branches       2511     2511              
============================================
+ Hits           7254     7303      +49     
+ Misses        11087    11082       -5     
  Partials        406      406
Flag Coverage Δ
editoast 71.36% <93.18%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/infra.rs 68.08% <88.88%> (+2.20%) ⬆️
editoast/src/views/infra/mod.rs 96.83% <94.28%> (-0.73%) ⬇️
editoast/src/map/bounding_box.rs 19.38% <0.00%> (-1.03%) ⬇️
editoast/src/generated_data/utils.rs 84.21% <0.00%> (+5.26%) ⬆️
editoast/src/schema/mod.rs 94.44% <0.00%> (+14.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@younesschrifi younesschrifi marked this pull request as draft February 1, 2023 23:47
Castavo
Castavo reviewed Feb 2, 2023
View reviewed changes
editoast/openapi.yaml Outdated Show resolved Hide resolved
flomonster
flomonster requested changes Feb 2, 2023
View reviewed changes
editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the mji/duplicateinfraendpoint branch 2 times, most recently from d9c8a69 to 2f2999d Compare February 6, 2023 10:03
@younesschrifi younesschrifi marked this pull request as ready for review February 6, 2023 10:03
@younesschrifi younesschrifi self-assigned this Feb 6, 2023
@younesschrifi younesschrifi force-pushed the mji/duplicateinfraendpoint branch 2 times, most recently from 2d91b36 to 26bd342 Compare February 6, 2023 16:32
flomonster
flomonster requested changes Feb 6, 2023
View reviewed changes
editoast/OSRD.session.sql Outdated Show resolved Hide resolved
editoast/src/infra.rs Show resolved Hide resolved
editoast/src/infra.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
@younesschrifi younesschrifi force-pushed the mji/duplicateinfraendpoint branch 2 times, most recently from d0a6944 to e23726d Compare February 8, 2023 23:03
@younesschrifi younesschrifi force-pushed the mji/duplicateinfraendpoint branch 2 times, most recently from c8311a7 to 624b34c Compare February 9, 2023 14:54
flomonster
flomonster requested changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Did you check the performances ?
Also you could add some comment about what you're doing in the main function.

editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
editoast/src/views/infra/mod.rs Outdated Show resolved Hide resolved
flomonster
flomonster previously approved these changes Feb 9, 2023
View reviewed changes
@younesschrifi younesschrifi force-pushed the mji/duplicateinfraendpoint branch 2 times, most recently from 65c58ac to 204764c Compare February 9, 2023 18:17
@flomonster flomonster enabled auto-merge (rebase) February 9, 2023 18:50
@flomonster flomonster merged commit 22ac6a9 into dev Feb 9, 2023
@flomonster flomonster deleted the mji/duplicateinfraendpoint branch February 9, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesschrifi younesschrifi younesschrifi left review comments

@Castavo Castavo Castavo left review comments

@bloussou bloussou bloussou left review comments

@flomonster flomonster flomonster approved these changes

Assignees

@younesschrifi younesschrifi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a duplicate infra endpoint to editoast
5 participants
@majaziri @flomonster @bloussou @Castavo @younesschrifi