Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: use rolling stock images and improve performance of the rolling stock card #3042

Merged
merged 2 commits into from
Jan 30, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Jan 30, 2023

closes #2956

@clarani clarani requested a review from a team as a code owner January 30, 2023 15:17
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #3042 (b2ba61d) into dev (68da147) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #3042      +/-   ##
============================================
- Coverage     39.00%   38.99%   -0.01%     
  Complexity     1705     1705              
============================================
  Files           606      606              
  Lines         18525    18528       +3     
  Branches       2495     2497       +2     
============================================
  Hits           7225     7225              
- Misses        10890    10893       +3     
  Partials        410      410              
Flag Coverage Δ
front 4.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/applications/opendata/components/TrainDetail.js 0.00% <0.00%> (ø)
.../applications/opendata/views/OpenDataTrainsList.js 0.00% <0.00%> (ø)
...rc/common/RollingStockSelector/RollingStock2Img.js 0.00% <0.00%> (ø)
...rc/common/RollingStockSelector/RollingStockCard.js 0.00% <0.00%> (ø)
...mon/RollingStockSelector/RollingStockCardDetail.js 0.00% <ø> (ø)
...c/common/RollingStockSelector/RollingStockModal.js 0.00% <0.00%> (ø)
...ommon/RollingStockSelector/RollingStockSelector.js 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@nicolaswurtz nicolaswurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job \o/

@nicolaswurtz nicolaswurtz merged commit c1c3796 into dev Jan 30, 2023
@nicolaswurtz nicolaswurtz deleted the cni/front-use-rs-images branch January 30, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt the frontend to use the rollingStock liveries
2 participants