-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: migrate to vite #3211
Merged
Merged
front: migrate to vite #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multun
force-pushed
the
migrate-to-vite
branch
4 times, most recently
from
February 20, 2023 17:24
57d03fe
to
64a6e5b
Compare
multun
force-pushed
the
migrate-to-vite
branch
from
February 20, 2023 17:37
64a6e5b
to
8840ea3
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3211 +/- ##
=============================================
+ Coverage 43.18% 66.86% +23.67%
Complexity 1874 1874
=============================================
Files 713 396 -317
Lines 20734 19094 -1640
Branches 2581 1487 -1094
=============================================
+ Hits 8955 12768 +3813
+ Misses 11296 5650 -5646
- Partials 483 676 +193
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
multun
force-pushed
the
migrate-to-vite
branch
from
February 20, 2023 17:45
8840ea3
to
e4e3ccb
Compare
front/src/applications/operationalStudies/components/SimulationResults/SpaceTimeChart.jsx
Outdated
Show resolved
Hide resolved
multun
force-pushed
the
migrate-to-vite
branch
2 times, most recently
from
February 21, 2023 09:27
43c4423
to
f09125d
Compare
multun
force-pushed
the
migrate-to-vite
branch
from
February 21, 2023 13:35
f09125d
to
fd95701
Compare
multun
force-pushed
the
migrate-to-vite
branch
3 times, most recently
from
February 21, 2023 19:12
0557bc1
to
9aa085f
Compare
alexandredamiron
previously approved these changes
Feb 22, 2023
multun
force-pushed
the
migrate-to-vite
branch
from
February 22, 2023 09:13
9aa085f
to
515a455
Compare
anisometropie
requested changes
Feb 22, 2023
Swc is an faster alternative to babel. Babel is still used for production builds. Please refer to the documentation of @vitejs/plugin-react-swc
Storybook 6 does not load vite.config.js. This is a huge issue, as all vite configuration would have to be replicated into storybook. Instead of writting hacks to backport this feature into storybook 6, switch to the 7 beta, which loads and configures everything by itself.
We cannot really use jest as it is tied to webpack. Vitest is a drop-in replacement for jest, which works with vite. I've added happy-dom as one of the tests starts up keycloak, which breaks without dom access. Jest emulates the dom by default.
multun
force-pushed
the
migrate-to-vite
branch
from
February 22, 2023 10:38
515a455
to
7b31018
Compare
alexandredamiron
approved these changes
Feb 22, 2023
anisometropie
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switch from react-create-app to vite:
Close #3215
Use swc for dev builds
Swc is an faster alternative to babel. Babel is still used for production builds.
Please refer to the documentation of @vitejs/plugin-react-swc
Migrate to storybook 7 beta
Storybook 6 does not load vite.config.js. This is a huge issue,
as all vite configuration would have to be replicated into storybook.
Instead of writting hacks to backport this feature into storybook 6,
switch to the 7 beta, which loads and configures everything by itself.
Migrate tests to vitest
We cannot really use jest as it is tied to webpack.
Vitest is a drop-in replacement for jest, which works with vite.
I've added happy-dom as one of the tests starts up keycloak,
which breaks without dom access. Jest emulates the dom by default.
Footnotes
development builds use swc, a faster alternative to babel ↩