Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: add operator =i for case insensitive "strict" equality #3275

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

leovalais
Copy link
Contributor

["=i", "tot", "ToT"]
# but not
["=i", "tot", "toto"] # differs from search

Useful for OP search as we want trigram strict equality, but we don't want to bother about the case (otherwise the front would need to known about DB internals).

@leovalais leovalais requested a review from a team as a code owner February 21, 2023 17:18
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #3275 (5074210) into dev (3dbd563) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

❗ Current head 5074210 differs from pull request most recent head 1257660. Consider uploading reports for the commit 1257660 to get more accurate results

@@             Coverage Diff              @@
##                dev    #3275      +/-   ##
============================================
- Coverage     40.36%   40.36%   -0.01%     
  Complexity     1711     1711              
============================================
  Files           630      630              
  Lines         18752    18753       +1     
  Branches       2342     2342              
============================================
  Hits           7570     7570              
- Misses        10780    10781       +1     
  Partials        402      402              
Flag Coverage Δ
editoast 71.31% <80.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/views/search/process.rs 92.20% <66.66%> (ø)
editoast/src/views/search/context.rs 83.63% <100.00%> (+0.30%) ⬆️
editoast/src/generated_data/utils.rs 78.94% <0.00%> (-5.27%) ⬇️
editoast/src/map/bounding_box.rs 19.38% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you amend your last commit?

Case-insensitive equality.
@leovalais leovalais merged commit c832efb into dev Mar 8, 2023
@leovalais leovalais deleted the lva/search-op-=i branch March 8, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants