Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: linter - enforce no-console rule + auto-fix #3313

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Feb 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3313 (e057405) into dev (401ac31) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #3313      +/-   ##
============================================
+ Coverage     67.82%   67.84%   +0.02%     
  Complexity     1876     1876              
============================================
  Files           398      398              
  Lines         19705    19698       -7     
  Branches       1498     1498              
============================================
  Hits          13365    13365              
+ Misses         5654     5647       -7     
  Partials        686      686              
Flag Coverage Δ
front 55.34% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ageTrainSchedule/Itinerary/ModalPathJSONDetail.jsx 15.06% <ø> (+0.20%) ⬆️
...nts/SimulationResults/simulationResultsHelpers.jsx 39.13% <0.00%> (ø)
front/src/reducers/osrdsimulation/simulation.js 25.38% <ø> (+0.19%) ⬆️
front/src/utils/helpers.js 31.78% <ø> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@clarani clarani force-pushed the cni/front/linter-no-console branch from e629c7e to e057405 Compare March 2, 2023 09:41
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Mar 2, 2023
@clarani clarani marked this pull request as ready for review March 2, 2023 12:56
@clarani clarani requested a review from a team as a code owner March 2, 2023 12:56
@alexandredamiron alexandredamiron merged commit ad34f7c into dev Mar 2, 2023
@alexandredamiron alexandredamiron deleted the cni/front/linter-no-console branch March 2, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants