Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: linter - enforce no-unused-var rule #3384

Merged
merged 1 commit into from
Mar 3, 2023
Merged

front: linter - enforce no-unused-var rule #3384

merged 1 commit into from
Mar 3, 2023

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 3, 2023

Closes #3383

@clarani clarani requested a review from a team as a code owner March 3, 2023 09:59
@clarani clarani added the area:front Work on Standard OSRD Interface modules label Mar 3, 2023
@clarani clarani force-pushed the cni/front/linter-no-unused-var branch from b37f1d7 to 12e17c6 Compare March 3, 2023 10:06
@clarani clarani closed this Mar 3, 2023
@clarani clarani reopened this Mar 3, 2023
@clarani clarani force-pushed the cni/front/linter-no-unused-var branch from 12e17c6 to f6cc498 Compare March 3, 2023 10:23
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #3384 (f6cc498) into dev (401ac31) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##                dev    #3384      +/-   ##
============================================
+ Coverage     67.82%   67.85%   +0.03%     
  Complexity     1876     1876              
============================================
  Files           398      398              
  Lines         19705    19698       -7     
  Branches       1498     1498              
============================================
+ Hits          13365    13367       +2     
+ Misses         5654     5645       -9     
  Partials        686      686
Flag Coverage Δ
front 55.36% <83.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/api/osrdEditoastApi.ts 92.55% <50.00%> (+0.01%) ⬆️
...c/common/BootstrapSNCF/ModalSNCF/ModalProvider.jsx 15.62% <100.00%> (+1.19%) ⬆️
front/src/reducers/osrdsimulation/simulation.js 25.38% <0.00%> (+0.19%) ⬆️
...ageTrainSchedule/Itinerary/ModalPathJSONDetail.jsx 15.06% <0.00%> (+0.20%) ⬆️
front/src/utils/helpers.js 31.78% <0.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Uriel-Sautron
Uriel-Sautron approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job !!

@clarani clarani merged commit a407f23 into dev Mar 3, 2023
@clarani clarani deleted the cni/front/linter-no-unused-var branch March 3, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uriel-Sautron Uriel-Sautron Uriel-Sautron approved these changes

@Math-R Math-R Math-R approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Front: linter - enforce @typescript-eslint/no-unused-vars
3 participants
@clarani @Math-R @Uriel-Sautron