Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yoh/fix switch train indicator in get #3428

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Mar 7, 2023

close #3102

@Yohh Yohh requested a review from a team as a code owner March 7, 2023 14:30
@Yohh Yohh marked this pull request as draft March 7, 2023 14:31
@Yohh Yohh force-pushed the yoh/fixSwitchTrainIndicatorInGet branch from f8b34b2 to ad60625 Compare March 9, 2023 10:02
@Yohh Yohh marked this pull request as ready for review March 9, 2023 10:04
@Yohh Yohh force-pushed the yoh/fixSwitchTrainIndicatorInGet branch 3 times, most recently from 3b7868d to dc9903a Compare March 9, 2023 11:00
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #3428 (fce6b2b) into dev (bb239c2) will decrease coverage by 0.05%.
The diff coverage is 21.42%.

❗ Current head fce6b2b differs from pull request most recent head a82a308. Consider uploading reports for the commit a82a308 to get more accurate results

@@             Coverage Diff              @@
##                dev    #3428      +/-   ##
============================================
- Coverage     67.73%   67.69%   -0.05%     
  Complexity     1880     1880              
============================================
  Files           404      404              
  Lines         19940    19951      +11     
  Branches       1501     1501              
============================================
- Hits          13506    13505       -1     
- Misses         5750     5762      +12     
  Partials        684      684              
Flag Coverage Δ
front 55.06% <21.42%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nts/SimulationResults/ChartHelpers/ChartHelpers.ts 36.39% <ø> (-0.19%) ⬇️
front/src/reducers/osrdsimulation/index.ts 47.73% <8.33%> (-2.27%) ⬇️
front/src/utils/timeManipulation.ts 57.14% <100.00%> (+1.26%) ⬆️
editoast/src/map/bounding_box.rs 27.55% <0.00%> (-2.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

… to get a decent timePosition; in drawTrain.jsx, update vertical-line in applyTrainCurveTranslation; in SpaceTimeChart.jsx, add offset in onOffsetTimeByDragging when apply dragShiftTrain

- pointer sticky on drag ending

- update positionValues on osrdSimulation reducer

- recreate pointer afetr drag

- corect behavior on rotate

- front: sampleData: fix prettier errors

- front: fix prettier errors

- front: fix prettier errors
@Yohh Yohh force-pushed the yoh/fixSwitchTrainIndicatorInGet branch from fce6b2b to a82a308 Compare March 9, 2023 12:46
@alexandredamiron alexandredamiron merged commit 77501ae into dev Mar 9, 2023
@alexandredamiron alexandredamiron deleted the yoh/fixSwitchTrainIndicatorInGet branch March 9, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: Timeline doesn't work anymore
2 participants