Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: properly clip tile geometry #3474

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Conversation

multun
Copy link
Contributor

@multun multun commented Mar 9, 2023

The mvt crate does not support geometry clipping. As a result, the transform from WebMercator into tile coordinate space has to be done by PostGIS.

Fixes #3164

The mvt crate does not support geometry clipping. As a result, the transform
from WebMercator into tile coordinate space has to be done by PostGIS.

Co-authored-by: bloussou <brieuc.loussouarn96@gmail.com>
@multun multun requested a review from a team as a code owner March 9, 2023 17:19
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #3474 (d9c837a) into dev (1f69491) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##                dev    #3474      +/-   ##
============================================
- Coverage     67.89%   67.88%   -0.01%     
  Complexity     1880     1880              
============================================
  Files           404      404              
  Lines         20067    20059       -8     
  Branches       1501     1501              
============================================
- Hits          13625    13618       -7     
+ Misses         5758     5757       -1     
  Partials        684      684              
Flag Coverage Δ
editoast 74.10% <75.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/views/layers/mod.rs 33.87% <0.00%> (ø)
editoast/src/views/layers/mvt_utils.rs 79.62% <100.00%> (+0.59%) ⬆️
editoast/src/map/bounding_box.rs 28.57% <0.00%> (-1.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@flomonster flomonster merged commit 5d29253 into dev Mar 9, 2023
@flomonster flomonster deleted the editoast-tile-clipping branch March 9, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect MVT tile encoding (line rendering when zooming is strange)
2 participants