Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add settings for VITE warnings & errors overlay #3557

Merged
merged 2 commits into from
Mar 16, 2023
Merged

front: add settings for VITE warnings & errors overlay #3557

merged 2 commits into from
Mar 16, 2023

Conversation

nicolaswurtz
Copy link
Contributor

@nicolaswurtz nicolaswurtz commented Mar 15, 2023 •
edited by Tguisnet
Loading

closes #3567

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner March 15, 2023 14:54
@nicolaswurtz nicolaswurtz added the area:front Work on Standard OSRD Interface modules label Mar 15, 2023
@nicolaswurtz nicolaswurtz self-assigned this Mar 15, 2023
@codecov
Copy link

codecov bot commented Mar 15, 2023 •
edited
Loading

Codecov Report

Merging #3557 (7869d10) into dev (70580ec) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #3557   +/-   ##
=========================================
  Coverage     68.02%   68.02%           
  Complexity     1896     1896           
=========================================
  Files           417      417           
  Lines         20827    20827           
  Branches       1534     1534           
=========================================
  Hits          14168    14168           
  Misses         5943     5943           
  Partials        716      716
Flag Coverage Δ
front 56.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

anisometropie
anisometropie approved these changes Mar 15, 2023
View reviewed changes
front/.env.local.defaults Outdated Show resolved Hide resolved
anisometropie
anisometropie requested changes Mar 15, 2023
View reviewed changes
front/vite.config.ts Show resolved Hide resolved
anisometropie
anisometropie previously approved these changes Mar 16, 2023
View reviewed changes
@nicolaswurtz nicolaswurtz enabled auto-merge (rebase) March 16, 2023 09:28
@nicolaswurtz nicolaswurtz merged commit a33a6bb into dev Mar 16, 2023
@nicolaswurtz nicolaswurtz deleted the nwz/vite-overlay-env-settings branch March 16, 2023 09:42
@Tguisnet Tguisnet added kind:bug Something isn't working severity:minor Minor severity bug and removed kind:bug Something isn't working area:front Work on Standard OSRD Interface modules severity:minor Minor severity bug labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisometropie anisometropie anisometropie approved these changes

Assignees

@nicolaswurtz nicolaswurtz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: add settings for VITE warnings & errors overlay
3 participants
@nicolaswurtz @anisometropie @Tguisnet