Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nwz/localization choice #3655

Merged
merged 3 commits into from
Mar 24, 2023
Merged

Nwz/localization choice #3655

merged 3 commits into from
Mar 24, 2023

Conversation

nicolaswurtz
Copy link
Contributor

No description provided.

@nicolaswurtz nicolaswurtz requested a review from a team as a code owner March 23, 2023 18:04
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #3655 (4ac1d83) into dev (1d5370c) will decrease coverage by 0.03%.
The diff coverage is 18.18%.

❗ Current head 4ac1d83 differs from pull request most recent head 99639ec. Consider uploading reports for the commit 99639ec to get more accurate results

@@             Coverage Diff              @@
##                dev    #3655      +/-   ##
============================================
- Coverage     68.16%   68.14%   -0.03%     
  Complexity     1918     1918              
============================================
  Files           424      424              
  Lines         21394    21405      +11     
  Branches       1555     1555              
============================================
+ Hits          14583    14586       +3     
- Misses         6079     6087       +8     
  Partials        732      732              
Flag Coverage Δ
front 56.78% <18.18%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/utils/strings.ts 40.00% <18.18%> (-12.64%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR :)

front/src/common/ChangeLanguage.tsx Outdated Show resolved Hide resolved
front/src/common/BootstrapSNCF/NavBarSNCF.jsx Outdated Show resolved Hide resolved
front/src/reducers/main.ts Outdated Show resolved Hide resolved
@nicolaswurtz nicolaswurtz force-pushed the nwz/localization-choice branch 2 times, most recently from 4ac1d83 to 658f66b Compare March 24, 2023 15:22
clarani
clarani previously approved these changes Mar 24, 2023
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, LGTM ! I have tested in local, no issue on my side :)

@nicolaswurtz nicolaswurtz removed the request for review from a team March 24, 2023 15:56
@nicolaswurtz nicolaswurtz merged commit 8104b15 into dev Mar 24, 2023
@nicolaswurtz nicolaswurtz deleted the nwz/localization-choice branch March 24, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants