Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix blocks with no zonepath #3669

Merged
merged 1 commit into from
Mar 24, 2023
Merged

core: fix blocks with no zonepath #3669

merged 1 commit into from
Mar 24, 2023

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Mar 24, 2023

No description provided.

Co-Authored-By: Victor "multun" Collod <victor.collod@epita.fr>
Co-Authored-By: Younes "Khoyo" Khoudli <younes.khoudli@epita.fr>
@Khoyo Khoyo requested a review from a team as a code owner March 24, 2023 15:15
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #3669 (d3634dc) into dev (1d5370c) will increase coverage by 0.01%.
The diff coverage is 30.76%.

@@             Coverage Diff              @@
##                dev    #3669      +/-   ##
============================================
+ Coverage     68.16%   68.18%   +0.01%     
- Complexity     1918     1928      +10     
============================================
  Files           424      424              
  Lines         21394    21498     +104     
  Branches       1555     1573      +18     
============================================
+ Hits          14583    14658      +75     
- Misses         6079     6096      +17     
- Partials        732      744      +12     
Flag Coverage Δ
core 78.92% <30.76%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/fr/sncf/osrd/sim_infra/impl/BlockInfraBuilder.kt 90.00% <0.00%> (-10.00%) ⬇️
...kotlin/fr/sncf/osrd/signaling/impl/BlockBuilder.kt 70.27% <25.00%> (-3.96%) ⬇️
.../fr/sncf/osrd/sim_infra_adapter/RawInfraAdapter.kt 90.62% <50.00%> (-0.91%) ⬇️

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Khoyo Khoyo enabled auto-merge (rebase) March 24, 2023 15:24
@multun multun disabled auto-merge March 24, 2023 15:24
@multun multun merged commit 07b74a0 into dev Mar 24, 2023
@multun multun deleted the fix-block-with-no-zonepath branch March 24, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants