Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nwz/modify timetable train 2 #3686

Merged
merged 31 commits into from
Apr 12, 2023
Merged

Nwz/modify timetable train 2 #3686

merged 31 commits into from
Apr 12, 2023

Conversation

nicolaswurtz
Copy link
Contributor

No description provided.

@nicolaswurtz nicolaswurtz added the area:front Work on Standard OSRD Interface modules label Mar 26, 2023
@codecov
Copy link

codecov bot commented Mar 26, 2023

Codecov Report

Merging #3686 (86e0898) into dev (c9f1ca1) will decrease coverage by 0.06%.
The diff coverage is 44.32%.

@@             Coverage Diff              @@
##                dev    #3686      +/-   ##
============================================
- Coverage     69.64%   69.59%   -0.06%     
  Complexity     2027     2027              
============================================
  Files           439      439              
  Lines         22083    22125      +42     
  Branches       1668     1670       +2     
============================================
+ Hits          15380    15397      +17     
- Misses         5905     5928      +23     
- Partials        798      800       +2     
Flag Coverage Δ
editoast 73.88% <ø> (ø)
front 59.01% <44.32%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
front/src/common/Pathfinding/Pathfinding.tsx 35.45% <3.70%> (-0.02%) ⬇️
front/src/reducers/osrdconf/index.ts 33.57% <31.42%> (-0.42%) ⬇️
front/src/utils/physics.ts 58.82% <60.00%> (-3.68%) ⬇️
...nts/SimulationResults/ChartHelpers/ChartHelpers.ts 42.40% <100.00%> (+0.16%) ⬆️
...ront/src/applications/operationalStudies/consts.ts 70.50% <100.00%> (+0.08%) ⬆️
front/src/common/api/osrdEditoastApi.ts 91.04% <100.00%> (ø)
front/src/common/api/osrdMiddlewareApi.ts 91.53% <100.00%> (+<0.01%) ⬆️
front/src/reducers/map/index.ts 49.38% <100.00%> (+0.15%) ⬆️
front/src/reducers/osrdconf/selectors.ts 80.95% <100.00%> (+0.62%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nicolaswurtz nicolaswurtz force-pushed the nwz/modify-timetable-train-2 branch 5 times, most recently from 3d9ec11 to a04d1a5 Compare April 3, 2023 16:24
@nicolaswurtz nicolaswurtz force-pushed the nwz/modify-timetable-train-2 branch 13 times, most recently from 9e831fc to 01cbd4f Compare April 11, 2023 16:05
@nicolaswurtz nicolaswurtz marked this pull request as ready for review April 11, 2023 16:17
@nicolaswurtz nicolaswurtz requested review from a team as code owners April 11, 2023 16:17
flomonster
flomonster previously approved these changes Apr 12, 2023
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openapi reviewed. 👍

front: updateTrain: in progress TO SQUASH PLS
front: updateTrain: begin to ajust store variables

front: updateTrain: try to add some infos to timetable
flomonster
flomonster previously approved these changes Apr 12, 2023
@flomonster flomonster requested a review from Math-R April 12, 2023 11:30
flomonster
flomonster previously approved these changes Apr 12, 2023
@Math-R Math-R enabled auto-merge (rebase) April 12, 2023 12:46
@Math-R Math-R merged commit 71cd75c into dev Apr 12, 2023
@Math-R Math-R deleted the nwz/modify-timetable-train-2 branch April 12, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants