Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editoast fix memory consumption 🚀 #3815

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Editoast fix memory consumption 🚀 #3815

merged 2 commits into from
Apr 5, 2023

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Apr 5, 2023

close #3122

  • Force close idle connection (to free libpq allocation)
  • Split the query to retrieve a railjson

Benchmark to retrieve a railjson from a large infra

Version Time (seconds) w/o ext Time (seconds) w/ ext
dev 13 12
split + deserialization 9 ?
split + no deserialization 6 4

@flomonster flomonster requested a review from a team as a code owner April 5, 2023 11:16
@flomonster flomonster marked this pull request as draft April 5, 2023 11:16
@flomonster flomonster marked this pull request as ready for review April 5, 2023 11:24
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #3815 (c56cb36) into dev (cc83322) will increase coverage by 0.02%.
The diff coverage is 88.23%.

@@             Coverage Diff              @@
##                dev    #3815      +/-   ##
============================================
+ Coverage     69.77%   69.80%   +0.02%     
  Complexity     2016     2016              
============================================
  Files           439      439              
  Lines         21951    21976      +25     
  Branches       1662     1662              
============================================
+ Hits          15317    15340      +23     
- Misses         5839     5841       +2     
  Partials        795      795              
Flag Coverage Δ
editoast 74.97% <88.23%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
editoast/src/main.rs 6.81% <0.00%> (-0.11%) ⬇️
editoast/src/views/infra/railjson.rs 89.79% <93.75%> (+5.18%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@flomonster flomonster requested a review from Tguisnet April 5, 2023 12:14
@flomonster flomonster merged commit 5d97af3 into dev Apr 5, 2023
@flomonster flomonster deleted the fam/fix-memory-issues branch April 5, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory spike when we retrieve a railjson (can lead to an OOM)
2 participants