Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: fix update of thermal rs curve and hover behavior #5230

Merged
merged 1 commit into from
Oct 10, 2023
Merged

front: fix update of thermal rs curve and hover behavior #5230

merged 1 commit into from
Oct 10, 2023

Conversation

SarahBellaha
Copy link
Contributor

Closes #5182 & #5091

@SarahBellaha SarahBellaha added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:rollingstocks-editor A module dedicated to rollingstock editors labels Oct 5, 2023
@SarahBellaha SarahBellaha requested a review from a team as a code owner October 5, 2023 15:41
@SarahBellaha SarahBellaha linked an issue Oct 5, 2023 that may be closed by this pull request
Trash icon remains after hovering elemets of the rolling stock curves editor #5091
Closed
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #5230 (d73de6c) into dev (be1aea7) will increase coverage by 0.21%.
Report is 31 commits behind head on dev.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##                dev    #5230      +/-   ##
============================================
+ Coverage     18.61%   18.83%   +0.21%     
  Complexity     2469     2469              
============================================
  Files           861      860       -1     
  Lines        106458   104546    -1912     
  Branches       2502     2499       -3     
============================================
- Hits          19818    19691     -127     
+ Misses        85271    83489    -1782     
+ Partials       1369     1366       -3
Flag Coverage Δ
front 7.02% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ts/RollingStockEditor/RollingStockEditorCurves.tsx 0.00% <0.00%> (ø)
front/src/common/SelectorSNCF.tsx 0.00% <0.00%> (ø)

... and 71 files with indirect coverage changes

clarani
clarani approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in local ✔️

@SarahBellaha SarahBellaha added this pull request to the merge queue Oct 10, 2023
Merged via the queue into dev with commit eb5d93f Oct 10, 2023
5 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/fix-update-thermal-curve branch October 10, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:rollingstocks-editor A module dedicated to rollingstock editors
Projects
None yet
Milestone
No milestone
2 participants
@SarahBellaha @clarani