Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix weird behavior in spreadsheet #5798

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

SarahBellaha
Copy link
Contributor

Closes #5793

@SarahBellaha SarahBellaha requested a review from a team as a code owner November 22, 2023 14:33
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e8ab630) 19.50% compared to head (4661d2a) 19.50%.

Files Patch % Lines
...ts/RollingStockEditor/RollingStockEditorCurves.tsx 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #5798      +/-   ##
============================================
- Coverage     19.50%   19.50%   -0.01%     
  Complexity     2332     2332              
============================================
  Files           907      907              
  Lines        107109   107112       +3     
  Branches       2590     2590              
============================================
  Hits          20893    20893              
- Misses        84693    84696       +3     
  Partials       1523     1523              
Flag Coverage Δ
front 8.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

@SarahBellaha SarahBellaha added this pull request to the merge queue Nov 22, 2023
Merged via the queue into dev with commit a2908ba Nov 22, 2023
6 of 7 checks passed
@SarahBellaha SarahBellaha deleted the sba/front/fix-spreadsheet-display branch November 22, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: spreadsheet cells behavior for curves editing is unpredictable
2 participants