front: synchronize speed space and space curves slopes charts #6031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahBellaha
force-pushed
the
sba/front/synchronize-space-speed-and-slopes-graphs
branch
2 times, most recently
from
f330672
to
a4c5ab5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6031 +/- ##
============================================
- Coverage 26.51% 26.49% -0.02%
Complexity 2117 2117
============================================
Files 930 931 +1
Lines 122743 122844 +101
Branches 2669 2670 +1
============================================
+ Hits 32543 32549 +6
- Misses 88623 88717 +94
- Partials 1577 1578 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SarahBellaha
force-pushed
the
sba/front/synchronize-space-speed-and-slopes-graphs
branch
3 times, most recently
from
bb0cc58
to
5d8c547
Compare
clarani
approved these changes
Dec 6, 2023
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChart.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/simulationResult/components/SpeedSpaceChart/SpeedSpaceChart.tsx
Outdated
Show resolved
Hide resolved
SarahBellaha
force-pushed
the
sba/front/synchronize-space-speed-and-slopes-graphs
branch
from
d3204d5
to
8e2ac5a
Compare
SarahBellaha
deleted the
sba/front/synchronize-space-speed-and-slopes-graphs
branch
| import * as d3 from 'd3'; | ||
| import { defineLinear } from './ChartHelpers'; | ||
|
|
||
| const getScaleDomainFromValues = (values: number[]) => { |
There was a problem hiding this comment.
is it not just d3.extent ?
There was a problem hiding this comment.
why do you need +100 ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5824