-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add e2e tests deleting a rolling stock #7851
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7851 +/- ##
============================================
- Coverage 28.33% 28.32% -0.01%
Complexity 2059 2059
============================================
Files 1270 1270
Lines 155543 155546 +3
Branches 3055 3055
============================================
- Hits 44070 44059 -11
- Misses 109649 109663 +14
Partials 1824 1824
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
64ce2e6
to
7d23b16
Compare
With @RomainValls, we found that the test does not pass 100% of the time, because the "delete" button is not visible if the rolling stock name is too long. The bug is known and is being resolved |
7d23b16
to
61df8e4
Compare
61df8e4
to
d154d7e
Compare
I added a data-testidto directly locate the buttons, and limited the length of the generated name by UUID to 6 characters, avoiding this problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests passed, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it works nice, just left one question for the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
Closes: #7774