front: ensure destination is last in formatSuggestedViasToRowVias() #8037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried isolating the logic in a function to avoid repetition, but ended up with something that was IMHO harder to read. (Maybe could have a function to do the |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8037 +/- ##
============================================
- Coverage 28.12% 28.11% -0.01%
Complexity 2112 2112
============================================
Files 1296 1296
Lines 158647 158659 +12
Branches 3164 3164
============================================
- Hits 44614 44611 -3
- Misses 112131 112146 +15
Partials 1902 1902
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SharglutDev
requested changes
Jul 12, 2024
emersion
force-pushed
the
emersion/reorder-dest-op
branch
from
013327b
to
979555f
Compare
4 tasks
(-1 || 0) is always evaluated to -1. We want to move the OP to the start of the array if we find it. If it's already at the start, the logic inside the conditional is a no-op.
Instead of toSpliced() + unshift(), we can use array destructuring to swap the first element with the one matching the origin.
The array has the type PathStep[], so not need to cast.
We were only handling the case where the path step is a UIC. Use matchPathStepAndOp() so that we handle all other cases (track offset, trigram, OP ID) correctly too.
Apply the same logic as the origin, but for the destination. See #8032 (comment)
flomonster
force-pushed
the
emersion/reorder-dest-op
branch
from
979555f
to
c9c1832
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits (some cleanups are also included).
See #8032 (comment)
Note, the first commit has been moved from #8032 to this PR to avoid merge conflicts.