-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: add shortslip distance checkbox in timestops #9275
front: add shortslip distance checkbox in timestops #9275
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9275 +/- ##
============================================
- Coverage 39.09% 39.07% -0.03%
Complexity 2267 2267
============================================
Files 1308 1308
Lines 99164 99176 +12
Branches 3312 3312
============================================
- Hits 38771 38754 -17
- Misses 58430 58459 +29
Partials 1963 1963
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested, works well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested. The name of the columns aren't exactly like in the issue but I guess it's on purpose
06bef62
to
61b0210
Compare
c04087e
to
b129296
Compare
Signed-off-by: romainvalls <romain.valls95@gmail.com>
b129296
to
828ee87
Compare
closes #8808