Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add shortslip distance checkbox in timestops #9275

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

RomainValls
Copy link
Contributor

closes #8808

@RomainValls RomainValls requested a review from a team as a code owner October 9, 2024 16:15
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.

Project coverage is 39.07%. Comparing base (600370b) to head (828ee87).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/modules/timesStops/helpers/utils.ts 7.14% 13 Missing ⚠️
...rc/modules/timesStops/hooks/useTimeStopsColumns.ts 0.00% 7 Missing ⚠️
front/src/modules/timesStops/TimesStopsInput.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9275      +/-   ##
============================================
- Coverage     39.09%   39.07%   -0.03%     
  Complexity     2267     2267              
============================================
  Files          1308     1308              
  Lines         99164    99176      +12     
  Branches       3312     3312              
============================================
- Hits          38771    38754      -17     
- Misses        58430    58459      +29     
  Partials       1963     1963              
Flag Coverage Δ
core 74.93% <ø> (ø)
editoast 71.96% <ø> (-0.06%) ⬇️
front 10.33% <4.34%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
osrdyne 3.30% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, left some comments

front/src/modules/timesStops/helpers/utils.ts Outdated Show resolved Hide resolved
front/src/modules/timesStops/helpers/utils.ts Outdated Show resolved Hide resolved
front/src/modules/timesStops/hooks/useTimeStopsColumns.ts Outdated Show resolved Hide resolved
front/public/locales/fr/timesStops.json Outdated Show resolved Hide resolved
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works well

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested. The name of the columns aren't exactly like in the issue but I guess it's on purpose

@RomainValls RomainValls force-pushed the rvs/front-add-shortslip-checkbox-in-timestops branch 2 times, most recently from 06bef62 to 61b0210 Compare October 10, 2024 10:46
@clarani clarani mentioned this pull request Oct 15, 2024
@RomainValls RomainValls force-pushed the rvs/front-add-shortslip-checkbox-in-timestops branch 7 times, most recently from c04087e to b129296 Compare October 22, 2024 06:31
Signed-off-by: romainvalls <romain.valls95@gmail.com>
@RomainValls RomainValls force-pushed the rvs/front-add-shortslip-checkbox-in-timestops branch from b129296 to 828ee87 Compare October 22, 2024 06:49
@RomainValls RomainValls added this pull request to the merge queue Oct 22, 2024
Merged via the queue into dev with commit a21994d Oct 22, 2024
24 checks passed
@RomainValls RomainValls deleted the rvs/front-add-shortslip-checkbox-in-timestops branch October 22, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: add "short slip distance" check-box next to closed-signal one
4 participants