Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented open-rarity computation logic for selected testsets #11

Merged
merged 9 commits into from
Jul 19, 2022
Merged

Implemented open-rarity computation logic for selected testsets #11

merged 9 commits into from
Jul 19, 2022

Conversation

impreso
Copy link
Contributor

@impreso impreso commented Jul 13, 2022

Tested by running locally over tested in data module.

vickygos
vickygos reviewed Jul 14, 2022
View reviewed changes
Copy link
Contributor

@vickygos vickygos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments! but lgtm

dadashi
dadashi approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@dadashi dadashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some typos

openrarity/resolver/testset_resolver.py Outdated Show resolved Hide resolved
openrarity/resolver/testset_resolver.py Outdated Show resolved Hide resolved
dadashi
dadashi approved these changes Jul 18, 2022
View reviewed changes
openrarity/resolver/testset_resolver.py Outdated Show resolved Hide resolved
vickygos
vickygos approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@vickygos vickygos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, not blocking, but for readability. Once fixed can merge. We can iterate with other PRs as well

@impreso impreso merged commit 539f8e4 into main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vickygos vickygos vickygos approved these changes

@dadashi dadashi dadashi approved these changes

@theelderbeever theelderbeever Awaiting requested review from theelderbeever

@jerome-qn jerome-qn Awaiting requested review from jerome-qn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@impreso @dadashi @vickygos