Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RaritySniper evaluation with fixes for sum formula #18

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

impreso
Copy link
Contributor

@impreso impreso commented Jul 28, 2022

  • Implemented the RaritySniper scores in the resolver script and added rank difference metrics for the RaritySniper.
  • Fixed the sum formula by applying trait normalization (changed formula from sum to dot)

Tests:

  1. Manually tested the script

Pytest passing:

pytest-xprocess reminder::Be sure to terminate the started process by running 'pytest --xkill' if you have not explicitly done so in your fixture with 'xprocess.getinfo(<process_name>).terminate()'.
(opensea-test) ➜  open-rarity git:(impreso/rarity_sniper) ✗ pytest
/Users/2gether/.pyenv/versions/3.10.3/envs/opensea-test/lib/python3.10/site-packages/apischema/__init__.py:66: UserWarning: graphql-core version 2.3.2 is incompatible with apischema;
GraphQL schema generation is thus not available.
  warnings.warn(
================================================================================================================ test session starts ================================================================================================================
platform darwin -- Python 3.10.3, pytest-7.1.2, pluggy-1.0.0
Using --randomly-seed=2100754547
rootdir: /Users/2gether/workspaces/open-rarity
plugins: anyio-3.6.1, xdist-2.5.0, forked-1.4.0, env-0.6.2, flaky-3.7.0, xprocess-0.18.1, ddtrace-1.1.2, vcr-1.0.2, mock-3.7.0, randomly-3.12.0, web3-5.29.0, dotenv-0.5.2, anchorpy-0.4.1, socket-0.5.1, django-4.5.2, subtests-0.7.0, cov-3.0.0
collected 8 items                                                                                                                                                                                                                                   

openrarity/tests/test_scoring.py ....                                                                                                                                                                                                         [ 50%]
openrarity/tests/test_collection.py ....                                                                                                                                                                                                      [100%]

================================================================================================================= 8 passed in 0.65s =================================================================================================================
pytest-xprocess reminder::Be sure to terminate the started process by running 'pytest --xkill' if you have not explicitly done so in your fixture with 'xprocess.getinfo(<process_name>).terminate()'.```

@impreso impreso requested a review from vickygos July 28, 2022 14:44
@impreso impreso linked an issue Jul 28, 2022 that may be closed by this pull request
@impreso impreso merged commit 1eb75e2 into main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RaritySniper support in the evaluation script
4 participants