-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain and modeling refactor #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
impreso
reviewed
Aug 3, 2022
open_rarity/resolver/rarity_providers/external_rarity_provider.py
Outdated
Show resolved
Hide resolved
impreso
reviewed
Aug 3, 2022
open_rarity/resolver/rarity_providers/external_rarity_provider.py
Outdated
Show resolved
Hide resolved
open_rarity/resolver/rarity_providers/external_rarity_provider.py
Outdated
Show resolved
Hide resolved
impreso
reviewed
Aug 8, 2022
impreso
reviewed
Aug 8, 2022
impreso
reviewed
Aug 8, 2022
impreso
reviewed
Aug 8, 2022
impreso
reviewed
Aug 8, 2022
grantli-os
reviewed
Aug 8, 2022
impreso
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM left additional feedback, but overall makes sense.
grantli-os
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
(UML Diagram)
Token
andCollection
to use the proposed interface that is multichain and interface friendlyTokenIdentifier
CollectionWithMetadata
andTokenWithRarityData
to specifically help with rarity resolvers and comparing rarityScorer
, and updated interface to properly score tokens based on collection + token inputs (and not modify said inputs)Open questions:
For follow-up PRs:
StringAttributeValue