Add GeometricMeanRarity #7
Conversation
|
The |
src/openrarity/scoring/base.py
Outdated
| @dataclass | ||
| class BaseRarityFormula: | ||
|
|
||
| formula_name: str |
There was a problem hiding this comment.
suggest to 1) create enum to provide explicit formula names 2) why we need formula id if we have a name?
There was a problem hiding this comment.
- we don't know what the names will be, a priori
- gp
src/openrarity/scoring/base.py
Outdated
| def score_token(token: Token) -> float: | ||
| raise NotImplementedError | ||
|
|
||
| # base aggregate scorers: can override more efficient methods |
There was a problem hiding this comment.
as discussed offline , can we create an efficient computation abstraction ( type alias should work it out) to perform batch-based computations in NumPy format.
There was a problem hiding this comment.
gp, we will create another class to batch computations in a future PR
| -- equivalent to the nth power of "statistical rarity" | ||
| ''' | ||
|
|
||
| def score_token(self, token: Token) -> float: |
There was a problem hiding this comment.
as a rule of thumb we should strike for 90% test coverage in the library - quality is very important to keep consistent computation.
There was a problem hiding this comment.
will write tests in future PR
| @@ -0,0 +1,296 @@ | |||
| [[package]] | |||
There was a problem hiding this comment.
why we need poetry lock again?
TODO: override aggregate calculations with vectorized methods