Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CPE dictionary #2097

Merged
merged 1 commit into from
May 9, 2024
Merged

Remove CPE dictionary #2097

merged 1 commit into from
May 9, 2024

Conversation

evgenyz
Copy link
Contributor

@evgenyz evgenyz commented Mar 19, 2024

Fixes: #1683

One dummy record is required by the scanner to be present.

One dummy record is required by the scanner to be present.
@jan-cerny
Copy link
Member

One dummy record is required by the scanner to be present.

@evgenyz Do you know why is this required? Can we do something so that it isn't required and we can remove it completely?

@jan-cerny jan-cerny self-assigned this May 2, 2024
@jan-cerny jan-cerny added this to the 1.4 milestone May 2, 2024
@evgenyz
Copy link
Contributor Author

evgenyz commented May 2, 2024

One dummy record is required by the scanner to be present.

@evgenyz Do you know why is this required? Can we do something so that it isn't required and we can remove it completely?

I was thinking about that. But then I realized that a dummy record, being fully valid at the same time, could be a good example for a maintainer that might want to adjust the dictionary. So I don't see it as particularly harmful.

@jan-cerny
Copy link
Member

But wouldn't removing the call to cpe_session_add_default_cpe from cpe_session_new?

@evgenyz
Copy link
Contributor Author

evgenyz commented May 2, 2024

But wouldn't removing the call to cpe_session_add_default_cpe from cpe_session_new?

Even if that's true, I'd probably still prefer to have this record as a demo of dictionary items.

@jan-cerny
Copy link
Member

there are some dictionary files that can be used as demo in the tests directory

@evgenyz
Copy link
Contributor Author

evgenyz commented May 2, 2024

there are some dictionary files that can be used as demo in the tests directory

How one would obtain that knowledge? Test suite is a rather enigmatict thing and we don't really have CPE dictionary well-documented. While this linux.* entry is 1) correct 2) right where it should be used 3) does not require any maintenance.

@jan-cerny jan-cerny merged commit 74043f7 into OpenSCAP:main May 9, 2024
18 checks passed
@evgenyz evgenyz deleted the remove-cpe-dict branch August 20, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove internal CPE dictionary
2 participants