Prevent crash in ObjectDetection (due to NULL parentClip) #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #915 +/- ##
===========================================
- Coverage 54.21% 53.68% -0.53%
===========================================
Files 190 182 -8
Lines 16592 16800 +208
===========================================
+ Hits 8995 9019 +24
- Misses 7597 7781 +184
... and 93 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…effects when using a child clip - Small refactor to Tracker and Object Detector drawImage code when drawing a Child Clip ID - Some light code clean-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect
child_clip_idfrom accessing NULLparentClip()pointer - which causes a crash when OpenShot attempts to update the JSON of an Object Detection effect with a child ID. Also fixing a GitHub CI issue, which is breaking the GitHub Checks/Actions.