Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not divide by zero when normalizing audio waveforms #916

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Apr 14, 2023

Do not divide by zero when normalizing audio waveforms full of 0.0 values. The bug caused a vector full of NaN instead of 0.0 values.

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #916 (a961d98) into develop (c472a24) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #916   +/-   ##
========================================
  Coverage    54.21%   54.21%           
========================================
  Files          190      190           
  Lines        16592    16592           
========================================
  Hits          8995     8995           
  Misses        7597     7597           
Impacted Files Coverage Δ
src/AudioWaveformer.cpp 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonoomph jonoomph merged commit e72168f into develop Apr 14, 2023
@jonoomph jonoomph deleted the normalize-zero-samples branch April 14, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant