Bug : Some component instances are still existing in the image after a cleanUp.

[Samuel29590]

When you start a system with Molecule and then you stop this system, there are some times some component instances that are still existing in the image.
They are visible by looking in the Inspect all component instances menu of Molecule after an execution of a Molecule system.

To reproduce

Lunch the GPS example, wait a little, and stop the example.

MolGPSExampleLauncher start.
"wait a little"
MolGPSExampleLauncher stop.

Then go on the Inspect all component instances menu of Molecule.
And here are the lost instances.

Fix

A solution to solve this problem is to do a garbage before opening this menu.

Smalltalk garbageCollect.

By doing that lost instances are remove from the Pharo image, and so they aren't visible from this menu. Furthermore, doing a garbage don't influence instances that are alive or using by a system, so this solution don't influence the menu's function.

[labordep]

Thanks Samuel.
Note : that's not a bug, the cleanUp clean only the current session of the ComponentManager (and also itself).
Some objects instances are not yet clean by the garbage collector, due to Smalltalk environement mecanism, I don't know when it's do but probably follwing a garbage cleanup policie. This is a new feature that consist to force the garbaging of stopped components when the ComponentManager>>cleanUp is done (for example).

[labordep]

I think this is better to do the garbageCollector by the ComponentManager, I think by the UI (on the menu) this is not the good place. UI need to show us a real state of the Component system and interferate the less (this is just a view). If there is some lost instances we need to clean that by a controller (I suggest the componentmanager) but not by calling only a UI function.

So, what do you think about grab the cleanup part of MolComponentManager>>flashComponents and to do the same thing at the end of the MolComponentManager>>cleanUp ? With that when you clean the system all stopped components will be automatically removed.

[Samuel29590]

Yes it's probably a better solution to do the garbage collector after cleanUp, than before opening the UI.
It will permit to cleanUp instances that are lost with the others, and that's better !

Your solution is good and better. So, let's go for that ?

[labordep]

Ok !
You can move your code from the UI to the MolComponentManager, and execute related unit-tests to confirm the patch :-)