Change: Stop calling OpenSFX a 'replacement' #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Danish and Swedish translations already do not call it a "replacement", simply a sound set, so they don't need to be updated. The Norwegian Bokmål translation however does need to be amended. |
orudge
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someone complained in IRC that OpenSFX/OpenMSX is called a 'replacement' which is severely underselling this base set. And I agree, it should not be called a 'replacement', it is perfectly valid in its own right.
This PR will change the description and README. Note the description file is changed again, which means the translations have to be reset (again). :-( Feel free to reject if you don't want to reset the translations.