Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Introduce and use ChunkHandler sub-classes #9413

merged 5 commits into from Jul 6, 2021


Copy link

@glx22 glx22 commented Jul 4, 2021

Motivation / Problem

ChunkHandler uses pointers to functions to determine what to do on saving, loading, load checking, pointer fixing.
That's a legacy of its C origin.


Move ChunkHandler to C++ world, and benefit from inheritance.

Diff is easier to read with "Hide whitespace changes" enabled.


Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

src/saveload/airport_sl.cpp Outdated Show resolved Hide resolved
src/saveload/economy_sl.cpp Outdated Show resolved Hide resolved
src/saveload/saveload.h Show resolved Hide resolved
src/saveload/saveload.h Outdated Show resolved Hide resolved
rubidium42 previously approved these changes Jul 6, 2021
@glx22 glx22 merged commit 7bcc7e1 into OpenTTD:master Jul 6, 2021
15 checks passed
@glx22 glx22 deleted the saveload branch Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants